pankajkoti commented on code in PR #32292:
URL: https://github.com/apache/airflow/pull/32292#discussion_r1250354344


##########
airflow/www/forms.py:
##########
@@ -220,9 +220,9 @@ class ConnectionForm(DynamicForm):
             ),
         )
         description = StringField(lazy_gettext("Description"), 
widget=BS3TextAreaFieldWidget())
-        host = StringField(lazy_gettext("Host"), widget=BS3TextFieldWidget())
+        host = StringField(lazy_gettext("Host"), widget=BS3TextFieldWidget(), 
filters=[strip_filter])
         schema = StringField(lazy_gettext("Schema"), 
widget=BS3TextFieldWidget())
-        login = StringField(lazy_gettext("Login"), widget=BS3TextFieldWidget())
+        login = StringField(lazy_gettext("Login"), 
widget=BS3TextFieldWidget(), filters=[strip_filter])

Review Comment:
   Well, I am not sure if stripping by default for all the fields would cause 
issues for someone's connections or not. If we're sure that it would not cause 
any issues then it is fine :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to