pankajkoti commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1274578621
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -321,7 +321,7 @@ def emit(self, record):
setattr(record, self.offset_field, int(time() * (10**9)))
self.handler.emit(record)
- def set_context(self, ti: TaskInstance) -> None:
+ def set_context(self, ti):
Review Comment:
okay, removed type override ignore by accepting kwargs. Hope that's okay if
tests pass.
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -321,7 +321,7 @@ def emit(self, record):
setattr(record, self.offset_field, int(time() * (10**9)))
self.handler.emit(record)
- def set_context(self, ti: TaskInstance) -> None:
+ def set_context(self, ti: TaskInstance) -> None: # type: ignore[override]
Review Comment:
Removed type override ignore by accepting kwargs. Hope that's okay if tests
pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
