pankajkoti commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1275125392
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -218,9 +225,17 @@ def close(self):
if self.handler:
self.handler.close()
- def _render_filename(self, ti: TaskInstance, try_number: int) -> str:
+ def _render_filename(self, ti_or_ti_key: TaskInstance | TaskInstanceKey,
try_number: int) -> str:
Review Comment:
I thought `ti` would correspond to `TaskInstance`. Since we also pass
`TaskInstanceKey` here from some places thought to rename this to indicate
that. I can avoid renaming if you prefer it that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
