pankajkoti commented on code in PR #33281:
URL: https://github.com/apache/airflow/pull/33281#discussion_r1289859531
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -98,6 +98,15 @@ def __init__(
log_id_template: str | None = None,
):
es_kwargs = es_kwargs or {}
+ # For elasticsearch>8,arguments like retry_timeout have changed for
elasticsearch to retry_on_timeout
+ # in Elasticsearch() compared to previous versions.
+ # Read more at:
https://elasticsearch-py.readthedocs.io/en/v8.8.2/api.html#module-elasticsearch
+ if es_kwargs:
+ retry_timeout = es_kwargs.get("retry_timeout")
Review Comment:
yes, I agree bumping something from x.y.z to x+1.y.z may not need to be a
breaking change in general. 👍🏽
However, would like to bring up and discuss the following point.
For this provider, elasticsearch is the main underlying dependency, and
we're updating it to the next major version from 7.x to 8.x. It does not affect
core Airflow code/functionality, but since providers are versioned and released
independently, upgrading to this provider release might affect existing
deployments for users.
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -98,6 +98,15 @@ def __init__(
log_id_template: str | None = None,
):
es_kwargs = es_kwargs or {}
+ # For elasticsearch>8,arguments like retry_timeout have changed for
elasticsearch to retry_on_timeout
+ # in Elasticsearch() compared to previous versions.
+ # Read more at:
https://elasticsearch-py.readthedocs.io/en/v8.8.2/api.html#module-elasticsearch
+ if es_kwargs:
+ retry_timeout = es_kwargs.get("retry_timeout")
Review Comment:
yes, I agree bumping something from x.y.z to x+1.y.z may not need to be a
breaking change in general. 👍🏽
However, would like to bring up and discuss the following point.
For this provider, elasticsearch is the main underlying dependency, and
we're updating it to the next major version from 7.x to 8.x. It does not affect
core Airflow code/functionality, but since providers are versioned and released
independently, upgrading to this provider release might affect existing
deployments for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
