eladkal commented on code in PR #33281:
URL: https://github.com/apache/airflow/pull/33281#discussion_r1289864897
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -98,6 +98,15 @@ def __init__(
log_id_template: str | None = None,
):
es_kwargs = es_kwargs or {}
+ # For elasticsearch>8,arguments like retry_timeout have changed for
elasticsearch to retry_on_timeout
+ # in Elasticsearch() compared to previous versions.
+ # Read more at:
https://elasticsearch-py.readthedocs.io/en/v8.8.2/api.html#module-elasticsearch
+ if es_kwargs:
+ retry_timeout = es_kwargs.get("retry_timeout")
Review Comment:
@ephraimbuddy I didn't see helm tests were broken?
and to my understanding this PR adds support for elastic search 8 so what is
the motivation for the breaking change?
> Also, maybe we should consider bumping to major versions whenever we bump
dependencies to major versions?
This was discussed and had lazy consequence if I remember correctly. Need to
lookup the thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
