vandonr-amz commented on code in PR #33452:
URL: https://github.com/apache/airflow/pull/33452#discussion_r1296320802
##########
airflow/configuration.py:
##########
@@ -1307,6 +1307,16 @@ def has_option(self, section: str, option: str) -> bool:
except (NoOptionError, NoSectionError):
return False
+ def set(self, section: str, option: str, value: str | None = None) -> None:
+ """
+ Set an option to the given value.
+
+ This override just makes sure the section and option are lower case,
to match what we do in `get`.
+ """
+ section = str(section).lower()
+ option = str(option).lower()
+ super().set(section, option, value)
Review Comment:
technically yes, but it'd only break code that was relying on the fact that
setting config values would not actually set them, which is pretty sketchy if
you ask me :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
