Lee-W commented on code in PR #33452:
URL: https://github.com/apache/airflow/pull/33452#discussion_r1296789070
##########
airflow/configuration.py:
##########
@@ -1307,13 +1307,25 @@ def has_option(self, section: str, option: str) -> bool:
except (NoOptionError, NoSectionError):
return False
+ def set(self, section: str, option: str, value: str | None = None) -> None:
+ """
+ Set an option to the given value.
+
+ This override just makes sure the section and option are lower case,
to match what we do in `get`.
+ """
+ section = str(section).lower()
+ option = str(option).lower()
+ super().set(section, option, value)
+
def remove_option(self, section: str, option: str, remove_default: bool =
True):
"""
Remove an option if it exists in config from a file or default config.
If both of config have the same option, this removes the option
in both configs unless remove_default=False.
"""
+ section = str(section).lower()
+ option = str(option).lower()
Review Comment:
```suggestion
section = section.lower()
option = option.lower()
```
##########
airflow/configuration.py:
##########
@@ -1307,13 +1307,25 @@ def has_option(self, section: str, option: str) -> bool:
except (NoOptionError, NoSectionError):
return False
+ def set(self, section: str, option: str, value: str | None = None) -> None:
+ """
+ Set an option to the given value.
+
+ This override just makes sure the section and option are lower case,
to match what we do in `get`.
+ """
+ section = str(section).lower()
+ option = str(option).lower()
Review Comment:
```suggestion
section = section.lower()
option = option.lower()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
