vandonr-amz commented on code in PR #33452:
URL: https://github.com/apache/airflow/pull/33452#discussion_r1297478624
##########
airflow/configuration.py:
##########
@@ -1307,13 +1307,25 @@ def has_option(self, section: str, option: str) -> bool:
except (NoOptionError, NoSectionError):
return False
+ def set(self, section: str, option: str, value: str | None = None) -> None:
+ """
+ Set an option to the given value.
+
+ This override just makes sure the section and option are lower case,
to match what we do in `get`.
+ """
+ section = str(section).lower()
+ option = str(option).lower()
Review Comment:
I copied what we do in `get` here
https://github.com/apache/airflow/blob/0fe6a607fc6f1678b678006fbea2ded068544f63/airflow/configuration.py#L953-L954
I suppose even though the type annotation is `str`, people can pass things
that are not strings, and we want to avoid crashing in that case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
