potiuk commented on code in PR #33605:
URL: https://github.com/apache/airflow/pull/33605#discussion_r1301515878
##########
.github/workflows/ci.yml:
##########
@@ -46,7 +46,7 @@ env:
secrets.CONSTRAINTS_GITHUB_REPOSITORY || 'apache/airflow' }}
# In builds from forks, this token is read-only. For scheduler/direct push
it is WRITE one
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- ENABLE_TEST_COVERAGE: "${{ github.event_name == 'push' }}"
+ ENABLE_TEST_COVERAGE: "true"
Review Comment:
I think this is "problematic". The reason why we do not run coverage for PRs
is that we have "selective checks" - basically every PR will run a different
subset of tests. If you only change google provider - only tests for core +
provider + all provider that depends on google are run, if you only change
"alibaba" - only alibaba provider tests are run. If you only change "cli" -
only CLi tests are run, and so one. Which gives enormous speed boost for vast
majority of PRs.
I think if we allow coverage for "pull_request" type of events it will get
even more "bumpy".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
