Taragolis commented on code in PR #33605:
URL: https://github.com/apache/airflow/pull/33605#discussion_r1301634016
##########
codecov.yml:
##########
@@ -25,7 +25,7 @@ codecov:
coverage:
precision: 2
round: down
- range: 55..80
+ range: 60..85
Review Comment:
Just cosmetic stuff. Since we have coverage around 84-86% so better
increase, otherwise most of the part would be close to the green range.
##########
.github/workflows/ci.yml:
##########
@@ -886,7 +886,7 @@ jobs:
DB_RESET: "false"
PYTHON_MAJOR_MINOR_VERSION:
"${{needs.build-info.outputs.default-python-version}}"
JOB_ID: "helm-tests"
- COVERAGE: "${{needs.build-info.outputs.run-coverage}}"
+ COVERAGE: "false" # We do not need to run coverage on Helm tests
Review Comment:
We already have `--no-cov` option for Helm, this change just in case
##########
.github/workflows/ci.yml:
##########
@@ -1089,6 +1089,7 @@ jobs:
MYSQL_VERSION: "${{matrix.mysql-version}}"
BACKEND_VERSION: "${{matrix.mysql-version}}"
JOB_ID: "mysql-${{matrix.mysql-version}}-${{matrix.python-version}}"
+ COVERAGE: "${{needs.build-info.outputs.run-coverage}}"
Review Comment:
Add missing coverage flag for MySQL tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
