potiuk commented on code in PR #33605:
URL: https://github.com/apache/airflow/pull/33605#discussion_r1301744650
##########
.github/workflows/ci.yml:
##########
@@ -46,7 +46,7 @@ env:
secrets.CONSTRAINTS_GITHUB_REPOSITORY || 'apache/airflow' }}
# In builds from forks, this token is read-only. For scheduler/direct push
it is WRITE one
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- ENABLE_TEST_COVERAGE: "${{ github.event_name == 'push' }}"
+ ENABLE_TEST_COVERAGE: "true"
Review Comment:
Ah yes. Because I split Providers into different groups to improve
parallelism. It does not have to be random (though maybe it makes sesne).
`-${TEST_TYPE/\[*\]/}` - this one removed what is added to `Providers[,,,,,]` -
> this is why coverage from three different provider groups have same name.
Yeah. Random suffix is probably good for coverage report.
##########
.github/workflows/ci.yml:
##########
@@ -46,7 +46,7 @@ env:
secrets.CONSTRAINTS_GITHUB_REPOSITORY || 'apache/airflow' }}
# In builds from forks, this token is read-only. For scheduler/direct push
it is WRITE one
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- ENABLE_TEST_COVERAGE: "${{ github.event_name == 'push' }}"
+ ENABLE_TEST_COVERAGE: "true"
Review Comment:
Very nice find :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
