Taragolis commented on code in PR #33720:
URL: https://github.com/apache/airflow/pull/33720#discussion_r1309348422
##########
airflow/models/taskreschedule.py:
##########
@@ -142,9 +154,93 @@ def find_for_task_instance(
:param try_number: Look for TaskReschedule of the given try_number.
Default is None which
looks for the same try_number of the given task_instance.
"""
- return TaskReschedule.query_for_task_instance(
- task_instance, session=session, try_number=try_number
- ).all()
+ return session.scalars(cls.stmt_for_task_instance(task_instance,
try_number=try_number)).all()
+
+ @classmethod
+ @provide_session
+ def find_last_for_task_instance(
Review Comment:
I change logic a bit methods
New (all marked as private):
`stmt_for_task_instance` -> Query builder
`find_task_reschedule_for_ti` -> Return single task_reschedule record, first
or last
`find_task_reschedules_for_ti` -> replacement for `find_for_task_instance`,
not used in production code, only in tests
Deprecated Methods, for backward compatibility
`query_for_task_instance`
`find_for_task_instance`
In general only `find_task_reschedule_for_ti` and `stmt_for_task_instance`
uses, all other are redundant, and in theory could be dropped. However
`find_task_reschedules_for_ti` help me to find my mistake during tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
