Taragolis commented on code in PR #33720:
URL: https://github.com/apache/airflow/pull/33720#discussion_r1305460117


##########
airflow/models/taskreschedule.py:
##########
@@ -94,18 +96,16 @@ def __init__(
         self.reschedule_date = reschedule_date
         self.duration = (self.end_date - self.start_date).total_seconds()
 
-    @staticmethod
-    @provide_session
+    @classmethod
     def query_for_task_instance(
+        cls,

Review Comment:
   I hope this class-methods not part of public interface, and we can change 
signature for migrate out of legacy SQLAlchemy Query API



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to