Taragolis commented on code in PR #33846:
URL: https://github.com/apache/airflow/pull/33846#discussion_r1311402279


##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -656,8 +656,6 @@ def _per_task_process(key, ti: TaskInstance, session):
                             _per_task_process(key, ti, session)
                             try:
                                 session.commit()
-                                # break the retry loop
-                                break

Review Comment:
   My personal opinion: nothing bad with break in `try` block, `try ... else` 
do not add viable benefits here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to