potiuk commented on code in PR #33846:
URL: https://github.com/apache/airflow/pull/33846#discussion_r1314692721
##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -656,8 +656,6 @@ def _per_task_process(key, ti: TaskInstance, session):
_per_task_process(key, ti, session)
try:
session.commit()
- # break the retry loop
- break
Review Comment:
I started to like more the try/except/**else**. It does have a nice
property where it clerly separates the "exception handling" logic with "no
exception" logic. In this case it does not add much value, but I think there is
an educational value. I think one reason we do not use it is that it's somewhat
under-used (even if pretty old) Python language construct and by using it in
more places in Airflow we might get people learn more about it and use more of
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
