potiuk commented on code in PR #33846:
URL: https://github.com/apache/airflow/pull/33846#discussion_r1314739413
##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -656,8 +656,6 @@ def _per_task_process(key, ti: TaskInstance, session):
_per_task_process(key, ti, session)
try:
session.commit()
- # break the retry loop
- break
Review Comment:
I tihin we can't enforce it, but we can at least have a lot examples in our
code that people learn to use it.
But yes. this is a bit of "tabs vs. spaces". Maybe worth discussing it at
the devlist what we prefer if this is controversial and get to lazy consensus
or even vote, This has been done multiple times in the past for various
conventions we use. We even enforced some of those. And as everything here - as
long as we agree on something as a convention, the "disagree but engage" rule
will kick in and we will all follow.
##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -656,8 +656,6 @@ def _per_task_process(key, ti: TaskInstance, session):
_per_task_process(key, ti, session)
try:
session.commit()
- # break the retry loop
- break
Review Comment:
I tihink we can't enforce it, but we can at least have a lot examples in our
code that people learn to use it.
But yes. this is a bit of "tabs vs. spaces". Maybe worth discussing it at
the devlist what we prefer if this is controversial and get to lazy consensus
or even vote, This has been done multiple times in the past for various
conventions we use. We even enforced some of those. And as everything here - as
long as we agree on something as a convention, the "disagree but engage" rule
will kick in and we will all follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
