potiuk commented on code in PR #34026:
URL: https://github.com/apache/airflow/pull/34026#discussion_r1315222653
##########
airflow/jobs/job.py:
##########
@@ -190,11 +182,10 @@ def heartbeat(
try:
# This will cause it to load from the db
- session.merge(self)
+ self._merge_from(Job._fetch_from_db(self, session))
Review Comment:
I tihnk we need to meet for an interactive brainstorming session and discuss
what's going on here. I believe there were some non-obvious behaviours of
heartbeat that we should replicate (especially around edge cases).
I tried recently to understand what's going on in this method and explain it
here:
https://github.com/apache/airflow/discussions/33689#discussioncomment-6820251
And I think it's not entirely obvious if we have the same now.
Let's discuss on slack @mhenc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
