uranusjr commented on code in PR #34026:
URL: https://github.com/apache/airflow/pull/34026#discussion_r1322483510
##########
airflow/jobs/job.py:
##########
@@ -309,8 +398,8 @@ def execute_job(job: Job | JobPydantic, execute_callable:
Callable[[], int | Non
database operations or over the Internal API call.
:param job: Job to execute - it can be either DB job or it's Pydantic
serialized version. It does
- not really matter, because except of running the heartbeat and state
setting,
- the runner should not modify the job state.
+ not really matter, because except of running the heartbeat and state
setting,
+ the runner should not modify the job state.
Review Comment:
Why change this? Doesn’t really matter but the indentation is good for
readability.
##########
airflow/jobs/job.py:
##########
@@ -309,8 +398,8 @@ def execute_job(job: Job | JobPydantic, execute_callable:
Callable[[], int | Non
database operations or over the Internal API call.
:param job: Job to execute - it can be either DB job or it's Pydantic
serialized version. It does
- not really matter, because except of running the heartbeat and state
setting,
- the runner should not modify the job state.
+ not really matter, because except of running the heartbeat and state
setting,
+ the runner should not modify the job state.
Review Comment:
Why change this? Doesn’t really matter but the indentation is good for
readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
