jens-scheffler-bosch commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1320765574
##########
airflow/models/taskinstance.py:
##########
@@ -436,6 +436,7 @@ class TaskInstance(Base, LoggingMixin):
next_method = Column(String(1000))
next_kwargs = Column(MutableDict.as_mutable(ExtendedJSON))
+ _task_display_name = Column("task_display_name", String(2000), default="")
Review Comment:
> Do you mean we should allow the DB colomn Nullable and fallback to
`task_id` if no display name is null (None in Python)?
>
Yes.
I hope nobody sets an empty string as display, but if we want to get into a
strong data validation (e.g. display need to be at least one character in
length) we can validate in python at point of dag parsing before it gets into
DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
