jens-scheffler-bosch commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1341965201
##########
airflow/models/taskinstance.py:
##########
@@ -436,6 +436,7 @@ class TaskInstance(Base, LoggingMixin):
next_method = Column(String(1000))
next_kwargs = Column(MutableDict.as_mutable(ExtendedJSON))
+ _task_display_name = Column("task_display_name", String(2000), default="")
Review Comment:
If the majority sees it different I don't want to block this PR and would
favor to move ahead. But for me an "empty"==undefined display value always
corresponds with NULL, not an empty string. Alongside thing about if you add
the DB Column during migration, the field per default will be set to NULL as
well. If you want to migrate existing tables making an empty stringas default
is another operation before being able to set a NOT NULL constraint.
In summay no major concerns but not convinced having an empty string as
default (I see no benefits just overhead).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
