jens-scheffler-bosch commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1324681847
##########
airflow/models/taskinstance.py:
##########
@@ -436,6 +436,7 @@ class TaskInstance(Base, LoggingMixin):
next_method = Column(String(1000))
next_kwargs = Column(MutableDict.as_mutable(ExtendedJSON))
+ _task_display_name = Column("task_display_name", String(2000), default="")
Review Comment:
From my DBA legacy (with MSSQL) I know that NULL needs less storage than an
empty string, don't know how it is with Postgres/MYSQL but I assume keeping it
NULL per default is saving storage space. So I also would prefer (1) (plus it
is safer, in cases somebody badly tries to check if `isinstance(db_value, str)`
for an empty string :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
