uranusjr commented on code in PR #34317: URL: https://github.com/apache/airflow/pull/34317#discussion_r1346974337
########## airflow/api_connexion/endpoints/dag_run_endpoint.py: ########## @@ -76,12 +77,7 @@ RESOURCE_EVENT_PREFIX = "dag_run" [email protected]_access( - [ - (permissions.ACTION_CAN_EDIT, permissions.RESOURCE_DAG), - (permissions.ACTION_CAN_DELETE, permissions.RESOURCE_DAG_RUN), - ], -) [email protected]_access_dag("DELETE", DagAccessEntity.RUN) Review Comment: Makes me wonder if it’s worthwhile to have a `requires_access_dag_run` shorthand ########## airflow/api_connexion/endpoints/dag_run_endpoint.py: ########## @@ -76,12 +77,7 @@ RESOURCE_EVENT_PREFIX = "dag_run" [email protected]_access( - [ - (permissions.ACTION_CAN_EDIT, permissions.RESOURCE_DAG), - (permissions.ACTION_CAN_DELETE, permissions.RESOURCE_DAG_RUN), - ], -) [email protected]_access_dag("DELETE", DagAccessEntity.RUN) Review Comment: Makes me wonder if it’s worthwhile to have a `requires_access_dag_run` shorthand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
