vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347839635
##########
airflow/api_connexion/endpoints/plugin_endpoint.py:
##########
@@ -22,13 +22,12 @@
from airflow.api_connexion.parameters import check_limit, format_parameters
from airflow.api_connexion.schemas.plugin_schema import PluginCollection,
plugin_collection_schema
from airflow.plugins_manager import get_plugin_info
-from airflow.security import permissions
if TYPE_CHECKING:
from airflow.api_connexion.types import APIResponse
[email protected]_access([(permissions.ACTION_CAN_READ,
permissions.RESOURCE_PLUGIN)])
[email protected]_access_website()
Review Comment:
Yes. [We decided to group
](https://github.com/apache/airflow/pull/33213#discussion_r1308050422)
`RESOURCE_PLUGIN`, `RESOURCE_PROVIDER`, `RESOURCE_TRIGGER` and
`RESOURCE_WEBSITE` into one category. Though, I specify the page (like we do
with DAGs) as a parameter in the follow-up PR. I have not created it because I
stop creating PR on top of another but basically I'll add that precision in the
next PR. So that the auth manager decide whether it has fine grained access to
the page level or just the category level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
