vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347826079
##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -111,13 +102,8 @@ def get_dag_run(*, dag_id: str, dag_run_id: str, session:
Session = NEW_SESSION)
return dagrun_schema.dump(dag_run)
[email protected]_access(
- [
- (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG),
- (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG_RUN),
- (permissions.ACTION_CAN_READ, permissions.RESOURCE_DATASET),
- ],
-)
[email protected]_access_dag("GET", DagAccessEntity.RUN)
[email protected]_access_dag("GET", DagAccessEntity.DATASET)
Review Comment:
Good point! There is a duplicate here. `DagAccessEntity.DATASET` does not
make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
