vincbeck commented on code in PR #34773:
URL: https://github.com/apache/airflow/pull/34773#discussion_r1347492888
##########
airflow/providers/amazon/aws/hooks/rds.py:
##########
@@ -240,7 +240,7 @@ def get_db_instance_state(self, db_instance_id: str) -> str:
try:
response =
self.conn.describe_db_instances(DBInstanceIdentifier=db_instance_id)
except self.conn.exceptions.ClientError as e:
- if e.response["Error"]["Code"] == "DBInstanceNotFoundFault":
+ if e.response["Error"]["Code"] == "DBInstanceNotFound":
Review Comment:
But service exceptions are wrapper into `ClientError`. See
[documentation](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/error-handling.html#aws-service-exceptions)
##########
airflow/providers/amazon/aws/hooks/rds.py:
##########
@@ -240,7 +240,7 @@ def get_db_instance_state(self, db_instance_id: str) -> str:
try:
response =
self.conn.describe_db_instances(DBInstanceIdentifier=db_instance_id)
except self.conn.exceptions.ClientError as e:
- if e.response["Error"]["Code"] == "DBInstanceNotFoundFault":
+ if e.response["Error"]["Code"] == "DBInstanceNotFound":
Review Comment:
But service exceptions are wrapped into `ClientError`. See
[documentation](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/error-handling.html#aws-service-exceptions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
