vincbeck commented on code in PR #34773:
URL: https://github.com/apache/airflow/pull/34773#discussion_r1347516080
##########
airflow/providers/amazon/aws/hooks/rds.py:
##########
@@ -240,7 +240,7 @@ def get_db_instance_state(self, db_instance_id: str) -> str:
try:
response =
self.conn.describe_db_instances(DBInstanceIdentifier=db_instance_id)
except self.conn.exceptions.ClientError as e:
- if e.response["Error"]["Code"] == "DBInstanceNotFoundFault":
+ if e.response["Error"]["Code"] == "DBInstanceNotFound":
Review Comment:
But [boto3
documentation](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/rds/client/describe_db_instances.html)
is different from [AWS API reference
documentation](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeDBInstances.html#API_DescribeDBInstances_Errors):
- Boto3 documentation: `DBInstanceNotFoundFault`
- API reference documentation: `DBInstanceNotFound`
I trust your testing then and `DBInstanceNotFound` should be the good one 👍
##########
airflow/providers/amazon/aws/hooks/rds.py:
##########
@@ -240,7 +240,7 @@ def get_db_instance_state(self, db_instance_id: str) -> str:
try:
response =
self.conn.describe_db_instances(DBInstanceIdentifier=db_instance_id)
except self.conn.exceptions.ClientError as e:
- if e.response["Error"]["Code"] == "DBInstanceNotFoundFault":
+ if e.response["Error"]["Code"] == "DBInstanceNotFound":
Review Comment:
But [boto3
documentation](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/rds/client/describe_db_instances.html)
is different from [AWS API reference
documentation](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeDBInstances.html#API_DescribeDBInstances_Errors):
- Boto3 documentation: `DBInstanceNotFoundFault`
- API reference documentation: `DBInstanceNotFound`
I trust your testing then and `DBInstanceNotFound` should be the good one 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
