Taragolis commented on code in PR #34773:
URL: https://github.com/apache/airflow/pull/34773#discussion_r1347569893


##########
airflow/providers/amazon/aws/hooks/rds.py:
##########
@@ -240,7 +240,7 @@ def get_db_instance_state(self, db_instance_id: str) -> str:
         try:
             response = 
self.conn.describe_db_instances(DBInstanceIdentifier=db_instance_id)
         except self.conn.exceptions.ClientError as e:
-            if e.response["Error"]["Code"] == "DBInstanceNotFoundFault":
+            if e.response["Error"]["Code"] == "DBInstanceNotFound":

Review Comment:
   Response Error Code != Exception name
   
   Some simple snippet for play with debugger
   
   ```python
   import boto3
   from botocore.exceptions import ClientError
   
   session = boto3.session.Session(...) # do not forget add creds/profile or 
set appropriate ENV Vars
   client = session.client("rds")
   
   
   try:
       client.describe_db_instances(DBInstanceIdentifier="foo-bar-spam-egg")
   except client.exceptions.DBInstanceNotFoundFault as ex:
       assert isinstance(ex, ClientError)
       assert isinstance(ex, client.exceptions.ClientError)
       raise
   ```
   
   
![image](https://github.com/apache/airflow/assets/3998685/6391325b-e045-45cf-b100-ac2ffaea535f)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to