ferruzzi commented on code in PR #34903:
URL: https://github.com/apache/airflow/pull/34903#discussion_r1357507527
##########
airflow/cli/commands/task_command.py:
##########
@@ -326,7 +326,7 @@ def _move_task_handlers_to_root(ti: TaskInstance) ->
Generator[None, None, None]
console_handler = next((h for h in root_logger.handlers if h.name ==
"console"), None)
with LoggerMutationHelper(root_logger), LoggerMutationHelper(ti.log) as
task_helper:
task_helper.move(root_logger)
- if IS_K8S_EXECUTOR_POD:
+ if IS_K8S_EXECUTOR_POD or IS_EXECUTOR_CONTAINER:
Review Comment:
Nittiest of nitpicks, non-blocking thought: in two places you use `if
IS_K8S_EXECUTOR_POD or IS_EXECUTOR_CONTAINER:`, I wonder if a calculated
constant somewhere like `IS_CONTAINERIZED = any(IS_K8S_EXECUTOR_POD,
IS_EXECUTOR_CONTAINER)`... but that's likely pointless overkill right now, but
if/when other providers add their own containerized executors, that may be
needed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
