uranusjr commented on code in PR #34903:
URL: https://github.com/apache/airflow/pull/34903#discussion_r1357747434
##########
airflow/cli/commands/task_command.py:
##########
@@ -326,7 +326,7 @@ def _move_task_handlers_to_root(ti: TaskInstance) ->
Generator[None, None, None]
console_handler = next((h for h in root_logger.handlers if h.name ==
"console"), None)
with LoggerMutationHelper(root_logger), LoggerMutationHelper(ti.log) as
task_helper:
task_helper.move(root_logger)
- if IS_K8S_EXECUTOR_POD:
+ if IS_K8S_EXECUTOR_POD or IS_EXECUTOR_CONTAINER:
Review Comment:
From another direction, it seems that `IS_EXECUTOR_CONTAINER` is never used
on its own, which makes me feel perhaps only the `IS_CONTAINERIZED` constant is
needed, and `IS_EXECUTOR_CONTAINER` can be removed entirely. The same applies
for the test parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
