o-nikolas commented on code in PR #34903:
URL: https://github.com/apache/airflow/pull/34903#discussion_r1360963519
##########
airflow/cli/commands/task_command.py:
##########
@@ -326,7 +326,7 @@ def _move_task_handlers_to_root(ti: TaskInstance) ->
Generator[None, None, None]
console_handler = next((h for h in root_logger.handlers if h.name ==
"console"), None)
with LoggerMutationHelper(root_logger), LoggerMutationHelper(ti.log) as
task_helper:
task_helper.move(root_logger)
- if IS_K8S_EXECUTOR_POD:
+ if IS_K8S_EXECUTOR_POD or IS_EXECUTOR_CONTAINER:
Review Comment:
Sorry folks (@ferruzzi @uranusjr), I thought I put enough details in the
description but perhaps I should have added more!
This new constant will be a generalized replacement for the K8s constant we
have now. Any new containerized executor should use this one. Which our new ECS
executor does use (link in description). I did not remove the K8s environment
variable in this PR to keep the scope small. This change is _just_ the core
pieces. The K8s executor will be migrated over to this env var in a follow up
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
