Taragolis commented on code in PR #35723:
URL: https://github.com/apache/airflow/pull/35723#discussion_r1398272604
##########
airflow/serialization/serialized_objects.py:
##########
@@ -498,7 +498,7 @@ def serialize(
type_=DAT.SIMPLE_TASK_INSTANCE,
)
elif isinstance(var, Connection):
- return cls._encode(var.to_dict(), type_=DAT.CONNECTION)
+ return cls._encode(var.to_json_dict(validate=True),
type_=DAT.CONNECTION)
Review Comment:
It should be backward compatible.
If connection serialized by previous version, it should be deserialized by
new one. I've also add test for that check.
I'm also not sure that we ever serialize connection in Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
