Taragolis commented on code in PR #35723:
URL: https://github.com/apache/airflow/pull/35723#discussion_r1398274754
##########
airflow/models/connection.py:
##########
@@ -496,3 +525,10 @@ def from_json(cls, value, conn_id=None) -> Connection:
except ValueError:
raise ValueError(f"Expected integer value for `port`, but got
{port!r} instead.")
return Connection(conn_id=conn_id, **kwargs)
+
+ @property
+ def json_repr(self) -> str:
Review Comment:
In first glance yes it is fine, however if some additional settings would
required in the future like indent or resolutions for empty hostname and schema
which parsed from the uri we could extend it by optional parameters.
In the other hand it is just a helper for create connection for environment
variable backend or some cloud based
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
