potiuk commented on code in PR #35723:
URL: https://github.com/apache/airflow/pull/35723#discussion_r1401874942
##########
airflow/models/connection.py:
##########
@@ -496,3 +525,10 @@ def from_json(cls, value, conn_id=None) -> Connection:
except ValueError:
raise ValueError(f"Expected integer value for `port`, but got
{port!r} instead.")
return Connection(conn_id=conn_id, **kwargs)
+
+ @property
+ def json_repr(self) -> str:
Review Comment:
> "There are only two hard things in Computer Science: cache invalidation
and naming things"
The second is also off-by-one mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
