Taragolis commented on code in PR #35820:
URL: https://github.com/apache/airflow/pull/35820#discussion_r1403531115
##########
airflow/providers/amazon/aws/fs/s3.py:
##########
@@ -45,7 +45,7 @@ class SignError(Exception):
"""Raises when unable to sign a S3 request."""
-def get_fs(conn_id: str | None) -> AbstractFileSystem:
+def get_fs(conn_id: str | None, storage_options: dict[str, str] | None) ->
AbstractFileSystem:
Review Comment:
```suggestion
def get_fs(conn_id: str | None, storage_options: dict[str, str] | None =
None) -> AbstractFileSystem:
```
##########
airflow/providers/google/cloud/fs/gcs.py:
##########
@@ -39,7 +39,7 @@
schemes = ["gs", "gcs"]
-def get_fs(conn_id: str | None) -> AbstractFileSystem:
+def get_fs(conn_id: str | None, storage_options: dict[str, str]) ->
AbstractFileSystem:
Review Comment:
```suggestion
def get_fs(conn_id: str | None, storage_options: dict[str, str] = None) ->
AbstractFileSystem:
```
##########
airflow/providers/microsoft/azure/fs/adls.py:
##########
@@ -27,7 +27,7 @@
schemes = ["abfs", "abfss", "adl"]
-def get_fs(conn_id: str | None) -> AbstractFileSystem:
+def get_fs(conn_id: str | None, storage_options: dict[str, Any] | None) ->
AbstractFileSystem:
Review Comment:
```suggestion
def get_fs(conn_id: str | None, storage_options: dict[str, Any] | None =
None) -> AbstractFileSystem:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
