uranusjr commented on code in PR #35820:
URL: https://github.com/apache/airflow/pull/35820#discussion_r1416951641
##########
airflow/io/__init__.py:
##########
@@ -32,21 +32,25 @@
if TYPE_CHECKING:
from fsspec import AbstractFileSystem
+ from airflow.io.typedef import Properties
Review Comment:
Why does this need a dedicated type alias? Do we plan to make it stricter
with say TypedDict? It feels to me it’s better to use `dict[str, str]` instead;
slightly repetitive but cognatively easier for readers.
##########
airflow/io/__init__.py:
##########
@@ -32,21 +32,25 @@
if TYPE_CHECKING:
from fsspec import AbstractFileSystem
+ from airflow.io.typedef import Properties
Review Comment:
Why does this need a dedicated type alias? Do we plan to make it stricter
with say TypedDict? It feels to me it’s better to use `dict[str, str]` instead;
slightly repetitive but cognatively easier for readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
