bolkedebruin commented on code in PR #35820:
URL: https://github.com/apache/airflow/pull/35820#discussion_r1420242140
##########
airflow/io/__init__.py:
##########
@@ -32,21 +32,25 @@
if TYPE_CHECKING:
from fsspec import AbstractFileSystem
+ from airflow.io.typedef import Properties
Review Comment:
I like the 'signal' of Properties that it automatically says I can only pass
[str, str] instead. To me it feels cognitive easier to see Properties than
dict[str, str] which has no semantic meaning and less error prone. But I am not
really tied up on it.
And yes maybe we could make it into a TypedDict
what do you say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
