potiuk commented on PR #36232: URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863594863
> Same error. I only disable the flag spellcheck for iteration #2 and #3. It should work since the issue is on the same package: `apache-airflow-providers-fab`. Though, interesting enough, the issue happen on `apache-airflow-providers` Yeah. That's the thing. This is what happens: 1. How `apache-airflow-providers` work. The `apache-airflow-providers` package extracts information from other providers and performs summary of "core extensions". In case of configuration changes it goes through the list of of all providers and finds out which one has the `configuration` defined, and based on that creates an "index" page where it links to configuration page of the `apache-airflow-providers-fab` provider. This is based on the current source code. So Sphinx expects that the configuration page is there. 2. Fetching the current inventory: If you unfold the commands running the spellcheck you will find this: ``` apache-airflow-providers-fab: Fetched inventory: http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow-providers-fab/stable/objects.inv ``` This means that before spellchecking start, the "current" inventory from s3 is fatched. This is the "inventory" of FAB provider that we pushed to s3 when it was built last time successfully. This inventory does NOT contain `configurations-ref` page because it was not there in main when the inventory was built 3. When 1st pass spellchecking starts for `apache-airflow-providers` the local `apache-airflow-providers-fab` sphix documentation is not built, so inventory is used. Without `configuration-ref` page In this case what SHOULD happen - we should rebuild all the packages and only THEN run spellchecking. That will first build all the packages and then, when we got them locally built, they will be used instead of inventory (and in this case, the `fab` one locally built will have the `configuration-ref` page. Looking at the output, I believe the 2nd psss did not happen at all. Possibly (without looking at the code) the 2nd pass is not currently executed at all when we have spellcheck only case ? Which I guess is logical, because you can't fix anything when you run spellcheck-only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
