potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863608620
I guessed correctly:
```
to_retry_packages = [
package_name
for package_name, errors in package_build_errors.items()
if any(any((m in e.message) for m in ERRORS_ELIGIBLE_TO_REBUILD) for
e in errors)
]
```
this list of `to_retry_packages` only checks `package_build_errors` not
`package_spelling_errors`.
And anyhow it would not work because if there are package spelling errors
and the flag `spellcheck_only` is true, you have to not only retry buillding
the failed package (`apache-airflow-providers`) but you also should ACTUALLY
BUILD the `apache-airflow-providers-fab` package. Only then the problem should
be solved.
So I'd say smthing like that should work:
In `retry_building_docs_if_needed`:
1) the to_retry_packages should also check `package_spelling_errors`
2) if `spellcheck_only` flag is set to `true` and there are any
`to_retry_packages` detected, then the `full` list of built packages should be
used. We currently do not have it inside the "retry_building_docs_if_needed" so
we need to pass it. the `spellcheck_only` should be set to `false` when calling
`build_docs_for_packages` again and all errors seen so far should be cleared
(both spelling and build ones) - because we ware rebuilding and spellchecking
all those packages from the scratch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
