potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863646937
OK. I think the problem is that spell-checking does not properly detect
"build" errors. I saw it in the past that when spelling fails with build
errors, there is no "actual" error printed. It's because it does:
```
spelling_errors.extend(parse_spelling_warnings(warning_text, self._src_dir))
```
and it does not do:
```
build_errors.extend(parse_sphinx_warnings(warning_text, self._src_dir))
```
So the "unknown document: 'apache-airflow-providers-fab:configurations-ref'"
is not added as "SpellingError" because it is not detected by
"parse_spelling_warnings".
I thing the
```
all_spelling_errors: dict[str, list[SpellingError]] = defaultdict(list)
```
should be changed to:
```
all_spelling_errors: dict[str, list[SpellingError|DocBuildError]] =
defaultdict(list)
```
(plus of course all the consequences) and both spelling and doc build errors
should be parsed and added there.
That should not only fix the problem but improve the output of
"--spell-check-only" when there is a build error (and not actual spelling
error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
