hussein-awala commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1435889890
##########
airflow/io/path.py:
##########
@@ -52,6 +52,9 @@ def __init__(
conn_id: str | None = None,
**kwargs: typing.Any,
) -> None:
+ # warning: we are not calling super().__init__ here
+ # as it will try to create a new fs from a different
+ # set if registered filesystems
Review Comment:
👍
##########
airflow/io/path.py:
##########
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
- return self._url.path
+ return self._url.path.lstrip(self.sep)
Review Comment:
Is this a bug fix? If so, moving it to a separate PR would be better,
because it looks like a breaking change in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
