uranusjr commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436030085
##########
airflow/io/path.py:
##########
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
- return self._url.path
+ return self._url.path.lstrip(self.sep)
Review Comment:
On the other hand, should we do a rstrip? That’s what Python’s pathlib does,
and while a trailing slash is technically significant in a URI, removing it
seems to make sense here since only one of the variants can make sense for any
particular existing resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
