uranusjr commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436018519
##########
airflow/io/path.py:
##########
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
- return self._url.path
+ return self._url.path.lstrip(self.sep)
Review Comment:
Lstrip a path doesn’t sound right to me; I’d instead prefer ensuring a slash
is present in the front. (Although tachnically the two probably are equivalent
since this is just a key and not actually semantically need to be a valid path…)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
