shahar1 commented on code in PR #36491:
URL: https://github.com/apache/airflow/pull/36491#discussion_r1439504202
##########
airflow/providers/google/cloud/transfers/bigquery_to_postgres.py:
##########
@@ -36,8 +34,6 @@ class BigQueryToPostgresOperator(BigQueryToSqlBaseOperator):
:param postgres_conn_id: Reference to :ref:`postgres connection id
<howto/connection:postgres>`.
"""
- template_fields: Sequence[str] =
(*BigQueryToSqlBaseOperator.template_fields, "dataset_id", "table_id")
Review Comment:
> Isn't this a breaking change?
>
> I think the real issue is with:
>
>
https://github.com/apache/airflow/blob/6802d4136fab9b8a02faf22f48cb9f6d259fd523/airflow/providers/google/cloud/transfers/bigquery_to_sql.py#L96-L99
>
> and it will affect all operators that inhert from the base class
Coming to think of it, it might be breaking indeed as fields that don't
exist in the parent's `template_fields` are removed from child's definition.
I suggest reverting it for now.
@romsharon98 instead of deleting this line, try to hardcode all of the
values that should be templated, and see if it works (a bit ugly, but I don't
have better idea for now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
