shahar1 commented on code in PR #36491:
URL: https://github.com/apache/airflow/pull/36491#discussion_r1442998946
##########
airflow/providers/google/cloud/transfers/bigquery_to_postgres.py:
##########
@@ -36,8 +34,6 @@ class BigQueryToPostgresOperator(BigQueryToSqlBaseOperator):
:param postgres_conn_id: Reference to :ref:`postgres connection id
<howto/connection:postgres>`.
"""
- template_fields: Sequence[str] =
(*BigQueryToSqlBaseOperator.template_fields, "dataset_id", "table_id")
Review Comment:
> @eladkal is right - but we shiould not revert it - instead we should ad
those to fields to the base class.
Sounds good to me.
A note from a technical perspective of the validation pre-commit -
As the validation is currently based on very simplified AST parsing, it
would be better for now to define the fields directly (i.e., `template_fields =
['a','b']`), rather than relying on parents' fields (i.e,
`template_fields=(**ParentClass.template_fields,'b')`)., otherwise the
validation might fail.
The cost would be minimal abuse to the inheritance, which can later be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
