romsharon98 commented on code in PR #36491:
URL: https://github.com/apache/airflow/pull/36491#discussion_r1439550974
##########
airflow/providers/google/cloud/transfers/bigquery_to_postgres.py:
##########
@@ -36,8 +34,6 @@ class BigQueryToPostgresOperator(BigQueryToSqlBaseOperator):
:param postgres_conn_id: Reference to :ref:`postgres connection id
<howto/connection:postgres>`.
"""
- template_fields: Sequence[str] =
(*BigQueryToSqlBaseOperator.template_fields, "dataset_id", "table_id")
Review Comment:
Thanks for your insight @eladkal !
Can you help me understand why is this breaking change?
This is how I understand it:
Lets assume I revert the PR, so both `"dataset_id", "table_id"` are
templated field for `BigQueryToPostgresOperator`.
But the parent constructor (`BigQueryToSqlBaseOperator`) always run them
over by the line you mentioned.
So as I understand it this reverted line has no meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
