potiuk commented on code in PR #36491:
URL: https://github.com/apache/airflow/pull/36491#discussion_r1443050583
##########
airflow/providers/google/cloud/transfers/bigquery_to_postgres.py:
##########
@@ -36,8 +34,6 @@ class BigQueryToPostgresOperator(BigQueryToSqlBaseOperator):
:param postgres_conn_id: Reference to :ref:`postgres connection id
<howto/connection:postgres>`.
"""
- template_fields: Sequence[str] =
(*BigQueryToSqlBaseOperator.template_fields, "dataset_id", "table_id")
Review Comment:
Correct. This is really what I also proposed - to move template_fields =
['dataset_id', 'template_id'] to `BigQueryToSqlBaseOperator`. This is where
they belong and this is what will make them consistent with the AST check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
