potiuk commented on PR #36537: URL: https://github.com/apache/airflow/pull/36537#issuecomment-1880193452
Hey here. I am not sure if this one is going to get green, but it's generally ready to review - I've addressed all my TODOs and It passes some basic verification. I've addressed all comments of @jscheffl and @uranusjr except two (see unresolved conversations) 1) not that important - question about all-dbs extra (is it useful? Should we remove it?) 2) more important, but likely the current choice is good - whether we should use `-` as separator in extra For the 2) I think @uranusjr maybe you can confirm my understanding that even if PEP-685 (https://peps.python.org/pep-0685) is not yet completely implemented in `pip` and other tools, generally speaking it should be backwards compatible and safe to change all our extras to use `-` instead of past `.` and `_`. I believe it is and we should just do it. The remaining steps (except review of course andmaking the PR green) is to verify the content of generated .whl and .sdist packages and compare it with previously generated packages and see that there are only changes we expected. Also I want to make sure the build is reproducible in the future, but that will include updating a bit the release process and adding the process to store and update the `[SOURCE_DATE_EPOCH](https://reproducible-builds.org/specs/source-date-epoch/)` in our reporsitory when preparing the release. But it can be done as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
