potiuk commented on code in PR #36537: URL: https://github.com/apache/airflow/pull/36537#discussion_r1445502072
########## dev/preinstalled_providers.json: ########## @@ -0,0 +1,9 @@ +[ + "http", + "common.io", + "common.sql", + "ftp", + "http", + "imap", + "sqlite" Review Comment: Because this file needs to be (ideally) read withoug installing any extra dependency. YAML requires installing pyyaml and since we want to read it in the "build environment" - which is created by adding hatchling and gitpython (and other transitive dependencies). If we add pyyaml to it, we need to install it (and all transitive dependencies every time `pip install` executes for Airflow. We do not want it. I actually considered (and maybe that's what I will do eventually) to use plain text file - same as we already do for installed_providers.txt - this is a file that contains list of providers that are installed in the production image by default. I actually think I will eventually do that, I just have to rename the original file (installed_providers.txt -> prod_image_providers.txt as there will be too big of an ambiguity). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
