potiuk commented on code in PR #36537:
URL: https://github.com/apache/airflow/pull/36537#discussion_r1445524535


##########
dev/preinstalled_providers.json:
##########
@@ -0,0 +1,9 @@
+[
+    "http",
+    "common.io",
+    "common.sql",
+    "ftp",
+    "http",
+    "imap",
+    "sqlite"

Review Comment:
   Yeah. Just following what was already done with `installed_providers.txt` is 
much better. I even had pre-commit that was sorting them :) that required just 
a small refactor to sort both. I also added comments capability to both of them 
to explain what they are for - now when there are two, better to explain more 
precisely what they are about.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to