amoghrajesh commented on code in PR #37692:
URL: https://github.com/apache/airflow/pull/37692#discussion_r1502019176
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -221,8 +221,12 @@ function check_boto_upgrade() {
echo
echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run
Amazon tests with them${COLOR_RESET}"
echo
- pip uninstall --root-user-action ignore aiobotocore s3fs -y || true
- pip install --root-user-action ignore --upgrade boto3 botocore
+ # shellcheck disable=SC2086
+ ${PACKAGING_TOOL} uninstall ${EXTRA_UNINSTALL_FLAGS} aiobotocore s3fs ||
true
Review Comment:
Do we not need a `-y` for these commands?
##########
Dockerfile:
##########
@@ -494,6 +498,36 @@ function common::get_colors() {
export COLOR_YELLOW
}
+function common::get_packaging_tool() {
+ if [[ ${AIRFLOW_USE_UV} == "true" ]]; then
+ echo
+ echo "${COLOR_BLUE}Using 'uv' to install Airflow${COLOR_RESET}"
+ echo
+ export PACKAGING_TOOL="uv pip"
+ export EXTRA_INSTALL_FLAGS=""
+ export EXTRA_UNINSTALL_FLAGS=""
+ export RESOLUTION_HIGHEST_FLAG="--resolution highest"
+ export RESOLUTION_LOWEST_DIRECT_FLAG="--resolution lowest-direct"
+ # We need to lie about VIRTUAL_ENV to make uv works
+ # Until https://github.com/astral-sh/uv/issues/1396 is fixed
+ # In case we are running user installation, we need to set VIRTUAL_ENV
to user's home + .local
Review Comment:
Example here would be nice to avoid confusion
##########
.github/workflows/ci.yml:
##########
@@ -175,7 +175,7 @@ jobs:
# We only push CI cache as PROD cache usually does not gain as much from
fresh cache because
# it uses prepared airflow and provider packages that invalidate the cache
anyway most of the time
push-early-buildx-cache-to-github-registry:
- timeout-minutes: 50
+ timeout-minutes: 110
Review Comment:
Is this because of the flaky test scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
